add skeletons for MantleBackup data synchronization #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ushitora-anqou
force-pushed
the
implement-interface-of-mantle-primary
branch
from
77d281a
to
3eb81bb
Compare
ushitora-anqou
changed the title
ushitora-anqou
force-pushed
the
implement-interface-of-mantle-primary
branch
3 times, most recently
from
3d2cfbd
to
78834f5
Compare
satoru-takeuchi
requested changes
Oct 4, 2024
| type dataSyncPrepareResult struct { | ||
| isIncremental bool | ||
| isSecondaryMantleBackupReadyToUse bool | ||
| diffFrom *mantlev1.MantleBackup // non-nil value iff isFull is false. |
There was a problem hiding this comment.
Suggested change
| diffFrom *mantlev1.MantleBackup // non-nil value iff isFull is false. | |
| diffFrom *mantlev1.MantleBackup // non-nil value iff isIncremental is true. |
There was a problem hiding this comment.
fixed in ae497fd
|
Note: I need to change the commit messages of some commits to reflect their fixed contents. |
ushitora-anqou
force-pushed
the
implement-interface-of-mantle-primary
branch
from
cbb4903
to
21c9c54
Compare
|
@satoru-takeuchi I think I've fixed all the issues you mentioned. Could you review this PR again? Note that I need to squash my fixup commits, so please don't merge it yet, even if the code looks good to you. |
satoru-takeuchi
approved these changes
Oct 9, 2024
ushitora-anqou
force-pushed
the
implement-interface-of-mantle-primary
branch
from
2e874d5
to
416bad5
Compare
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
ushitora-anqou
force-pushed
the
implement-interface-of-mantle-primary
branch
from
416bad5
to
a44590a
Compare
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
ushitora-anqou
force-pushed
the
implement-interface-of-mantle-primary
branch
from
a44590a
to
d399763
Compare
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
…ess after calling it Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
ushitora-anqou
force-pushed
the
implement-interface-of-mantle-primary
branch
from
d399763
to
6d1d1e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.